Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter name standardization #503

Closed
KamasamaK opened this issue Dec 24, 2017 · 2 comments
Closed

Parameter name standardization #503

KamasamaK opened this issue Dec 24, 2017 · 2 comments
Assignees
@ryaneberly
Labels
enhancement
Milestone
1.3.0

Comments

@KamasamaK
Copy link
Collaborator

Now that parameters are more user-facing, I think the naming convention of parameters should be standardized. I prefer them being camelCase but some of them are PascalCase.
@KamasamaK KamasamaK added this to the 1.3.0 milestone Dec 24, 2017
@KamasamaK KamasamaK mentioned this issue Dec 25, 2017
Merged
ryaneberly added a commit that referenced this issue Dec 28, 2017
@ryaneberly
#503
7eb4240
@ryaneberly ryaneberly self-assigned this Dec 28, 2017
@KamasamaK
Copy link
Collaborator Author

@ryaneberly Thanks! I think there were some unintended changes to setters in ValidName.java.

ryaneberly added a commit that referenced this issue Dec 28, 2017
@ryaneberly
#503 undo misnamed setters
0fb06c6
@ryaneberly
Copy link
Contributor

fixed in dev. Thanks @KamasamaK .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryaneberly ryaneberly

Labels
enhancement
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@ryaneberly @KamasamaK