Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPONENT_* errors quote displayName instead of filename #469

Closed
zspitzer opened this issue Sep 15, 2017 · 1 comment
Closed

COMPONENT_* errors quote displayName instead of filename #469

zspitzer opened this issue Sep 15, 2017 · 1 comment
Assignees
Milestone

Comments

@zspitzer
Copy link

rather than TestComp, the following lint warnings should quote veryLongComponentName.cfc

Severity:INFO
Message code:COMPONENT_INVALID_NAME
	File:S:\wwwroot\veryLongComponentName.cfc
	Column:0
	Line:1
		Message:Component name TestComp is not a valid name. Please use CamelCase and start with a capital letter.
		Variable:'null' in function: 
		Expression:<cfcomponent hint="test" displayName="TestComp">
<cffunction name="testFunction" displayname="" access="public" output="false" returntype="void" hint="no close tag">
</cffunction>
</cfcomponent>
Issue
Severity:INFO
Message code:COMPONENT_TOO_WORDY
	File:S:\wwwroot\veryLongComponentName.cfc
	Column:0
	Line:1
		Message:Component name TestComp is too wordy, can you think of a more concise name?
		Variable:'null' in function: 
		Expression:<cfcomponent hint="test" displayName="TestComp">
<cffunction name="testFunction" displayname="" access="public" output="false" returntype="void" hint="no close tag">
</cffunction>
</cfcomponent>
Issue
Severity:INFO
Message code:COMPONENT_TOO_LONG
	File:S:\wwwroot\veryLongComponentName.cfc
	Column:0
	Line:1
		Message:Component name TestComp should be shorter than 15 characters.
		Variable:'null' in function: 
		Expression:<cfcomponent hint="test" displayName="TestComp">
<cffunction name="testFunction" displayname="" access="public" output="false" returntype="void" hint="no close tag">
</cffunction>
</cfcomponent>

veryLongComponentName.cfc.txt

@ryaneberly ryaneberly added this to the 1.3.0 milestone Oct 14, 2017
ryaneberly added a commit that referenced this issue Dec 24, 2017
@ryaneberly ryaneberly self-assigned this Dec 24, 2017
@ryaneberly
Copy link
Contributor

Thanks @zspitzer . This is fixed in dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants