Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated message in stdout #448

Closed
KamasamaK opened this issue Aug 16, 2017 · 9 comments
Closed

Deprecated message in stdout #448

KamasamaK opened this issue Aug 16, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@KamasamaK
Copy link
Collaborator

Starting with CFLint v1.2.2, the message indicating deprecated features is being written to stdout and breaking anything that expects stdout to just be the standard output. In other words, it is not parsable as JSON or XML with that message.

@TheRealAgentK TheRealAgentK self-assigned this Aug 17, 2017
@TheRealAgentK TheRealAgentK added this to the 1.3.0 milestone Aug 17, 2017
@KamasamaK
Copy link
Collaborator Author

This message was removed in 4330edd. In the future, I think messages like these should be written to System.err so as to not break stdout parsing.

@ryaneberly
Copy link
Contributor

Sounds like this is resolved.

@TheRealAgentK
Copy link
Collaborator

Do we still need to keep the messages in place though (writing to System.err) because those features are now due to be removed in 1.4.0?

ryaneberly added a commit that referenced this issue Dec 29, 2017
@ryaneberly
Copy link
Contributor

I think they should stay in 1.3.0 and then be dropped. Is that what you are saying @TheRealAgentK ?

@KamasamaK
Copy link
Collaborator Author

Can the message only be written when one of those parameters is defined within the .cflintrc? I believe it was previously written regardless.

@TheRealAgentK
Copy link
Collaborator

@ryaneberly What I meant was that after you removed them in 4330edd correctly for 1.3.0 - we now have pushed the actual removal to 1.4.0. So, we should bring the messages back, but instead pushing them to .out, to .err.

@KamasamaK Yes, that's a really good suggestion.

@ryaneberly
Copy link
Contributor

@TheRealAgentK . Yes it is removed globally, but I think it is doing what @KamasamaK suggested.
see com.cflint.config.CFLintConfig.setInheritPlugins() and setOutput(). They display a warning on syserr when the setter is invoked.

@KamasamaK
Copy link
Collaborator Author

Excellent. So the messages just need to be updated from saying "will be fully removed in CFLint 1.3.0" to "will be fully removed in CFLint 1.4.0".

ryaneberly added a commit that referenced this issue Dec 29, 2017
@ryaneberly
Copy link
Contributor

Good point. TCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants