Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLOBAL_LITERAL_VALUE_USED_TOO_OFTEN triggered on CF_SQL_ #340

Closed
KamasamaK opened this issue Jul 8, 2017 · 2 comments
Closed

GLOBAL_LITERAL_VALUE_USED_TOO_OFTEN triggered on CF_SQL_ #340

KamasamaK opened this issue Jul 8, 2017 · 2 comments

Comments

@KamasamaK
Copy link
Collaborator

I have script components with addParam() for parameterizing queries, and the setting cfsqltype within it to the enumerated values like "CF_SQL_INTEGER" and "CF_SQL_VARCHAR" is triggering GLOBAL_LITERAL_VALUE_USED_TOO_OFTEN. Does it make sense to make variables for those values or should it ignore them?

@ryaneberly
Copy link
Contributor

Good point. That should be changed.

spService.addParam(cfsqltype="cf_sql_varchar", type="in",value=form.title);

ryaneberly added a commit that referenced this issue Jul 13, 2017
@ryaneberly
Copy link
Contributor

Added a harded exclusion to LiteralChecker for any literal starting with cf_sql_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants