Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Rules merging with config.xml #260

Closed
msp1kpj opened this issue Mar 15, 2017 · 2 comments
Closed

Default Rules merging with config.xml #260

msp1kpj opened this issue Mar 15, 2017 · 2 comments

Comments

@msp1kpj
Copy link
Contributor

msp1kpj commented Mar 15, 2017

plugin-error Message code: AVOID_USING_CFDUMP_TAG is not configured correctly.at line 1 col 1
plugin-error Message code: AVOID_USING_CFABORT_TAG is not configured correctly.at line 1 col 1
plugin-error Message code: ARG_VAR_MIXED is not configured correctly.at line 1 col 1
plugin-error Message code: METHOD_INVALID_NAME is not configured correctly.at line 1 col 1
plugin-error Message code: METHOD_IS_TEMPORARY is not configured correctly.at line 1 col 1

With release 1.0.1 Have had to add additional Message rules to my cflintconfig.xml. I have been using the cflint.definition.json file to help recreate these rule. It seems like the default rules and messages are not merging together with the rule overrides. I tries copying the cflint.definition.json file and make my modification but I am not able to use that file to import.

Does Not Work
"java.exe" -jar "CFLint-1.0.1-all.jar" -e -stdout -file Service.cfc -xml -filterFile "cflintexclude.json" -configfile "cflint.definition.json"
Unable to load config file. Unrecognized field "rules" (class com.cflint.config.CFLintConfig), not marked as ignorable (6 known properties: "output", "inheritParent", "excludes", "includes", "rule", "inheritPlugins"])
at [Source: java.io.FileInputStream@3159c4b8; line: 2, column: 13] (through reference chain: com.cflint.config.CFLintConfig["rules"])

Works but Does Not Merge rules
"java.exe" -jar "CFLint-1.0.1-all.jar" -e -stdout -file Service.cfc -xml -filterFile "cflintexclude.json" -configfile "cflintconfig.xml"

ryaneberly added a commit that referenced this issue Mar 31, 2017
@ryaneberly
Copy link
Contributor

@msp1kpj , I believe it is fixed. Thank you. Do you mind confirming?

@ryaneberly
Copy link
Contributor

.. in the dev branch.

ryaneberly added a commit that referenced this issue Apr 20, 2017
support CFLintConfig and CFLintPluginInfo xmls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants