Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML report includes semicolon after PLUGIN_ERROR id and message #241

Closed
mpaluchowski opened this issue Feb 20, 2017 · 1 comment
Closed

Comments

@mpaluchowski
Copy link
Contributor

When scanning the following test.cfm file:

<cfscript>
  defaultFontColor = "##444444";
</cfscript>

with java -jar CFLint-1.0.0-all.jar -file test.cfm -xml, the XML report contains:

<?xml version="1.0" encoding="UTF-8" ?>
<issues version="1.0.0">
  <issue severity="ERROR" id="PLUGIN_ERROR:" message="PLUGIN_ERROR:" category="CFLint" abbrev="PE">
    <location file="test.cfm" fileName="test.cfm" function="" column="1" line="1" message="" variable="">
      <Expression><![CDATA[]]></Expression>
    </location>
  </issue>
  <issue severity="ERROR" id="PLUGIN_ERROR" message="PLUGIN_ERROR" category="CFLint" abbrev="PE">
    <location file="test.cfm" fileName="test.cfm" function="" column="22" line="2" message="Error in plugin: class java.lang.NullPointerException" variable="class java.lang.NullPointerException">
      <Expression><![CDATA[]]></Expression>
    </location>
  </issue>
</issues>

The first issue incorrectly contains a semicolon : after PLUGIN_ERROR in id and message attributes. The second one is fine. If there are more plugin errors from the same file, then most of them have the erroneous semicolon.

Of course, these errors shouldn't be triggered for the file in the first place, but that's already reported in #240.

ryaneberly added a commit to cfparser/cfparser that referenced this issue Feb 22, 2017
ryaneberly added a commit that referenced this issue Feb 22, 2017
@ryaneberly
Copy link
Contributor

fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants