Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules reporting missing hints should work with script-style code #199

Closed
mpaluchowski opened this issue Oct 7, 2016 · 3 comments
Closed

Rules reporting missing hints should work with script-style code #199

mpaluchowski opened this issue Oct 7, 2016 · 3 comments

Comments

@mpaluchowski
Copy link
Contributor

The three rules:

  • Function is missing a hint.
  • Component is missing a hint.
  • Argument is missing a hint.

work only when a component is in CFML. Can they be extended to work with script code too?
@ryaneberly
Copy link
Contributor

@mpaluchowski , good suggestion. It looks like functions can be hinted in 3 ways in cfscript.

  • a hint attribute
  • @hint in a multiline comment
  • the entire multiline comment is a hint.
    ?
    Do you agree

@mpaluchowski
Copy link
Contributor Author

Yes, agree :)

ryaneberly added a commit that referenced this issue Oct 23, 2016
@ryaneberly
#199
1b07e49 
added hint checking for cfscript: components,functions,arguments.
@ryaneberly
Copy link
Contributor

@mpaluchowski ,
this is implemented. Note: the only valid way to hint arguments in cfscript seems to be javadoc style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpaluchowski @ryaneberly