Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAR_ALLCAPS_NAME handles scope #147

Closed
bardware opened this issue Feb 14, 2016 · 2 comments
Closed

VAR_ALLCAPS_NAME handles scope #147

bardware opened this issue Feb 14, 2016 · 2 comments

Comments

@bardware
Copy link

Me again :)

I run test VAR_ALLCAPS_NAME on a CFC and get results like:

Message:Variable LOCAL should not be upper case.
Message:Variable SESSION should not be upper case.

It maybe should ignore the notation of the scopes LOCAL, THIS, VARIABLES, ARGUMENTS and care for the actual name.

@justinmclean
Copy link
Contributor

IMO scopes should be in lower case but I can see that some people way want to upper case CGI or URL or possibly other scopes. When I have some time later this week I'll break the rule into two, one to check for the scope and the other the variable name. That way you can turn off the scope one if you have lots of uppercase scopes.

@justinmclean
Copy link
Contributor

Added new rule "SCOPE_ALL_CAPS" so you can check both errors and/or turn off SCOPE_ALL_CAPS if you want.

ryaneberly added a commit that referenced this issue May 1, 2016
added ignore uppercase URL and CGI scopes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants