Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVOID_USING_CFMODULE_TAG appears too often #145

Closed
bardware opened this issue Feb 13, 2016 · 3 comments
Closed

AVOID_USING_CFMODULE_TAG appears too often #145

bardware opened this issue Feb 13, 2016 · 3 comments
Assignees

Comments

@bardware
Copy link

I have a .cfm file with the content:

<cfinclude template="incl.cfm">
<cfmodule template="incl.cfm">

I run CFLint-0.6.1-all.jar -includeRule AVOID_USING_CFINCLUDE_TAG,AVOID_USING_CFINCUDE_TAG,AVOID_USING_CFMODULE_TAG and receive one result: Avoid using <cfmodule> tags.
It seems test AVOID_USING_CFINCLUDE_TAGis only executed inside a component. That looks right to me. Why is the CFINCLUDE test executed without the check for component?

@justinmclean justinmclean self-assigned this Feb 13, 2016
@justinmclean
Copy link
Contributor

cfinclude can be use outside of components to good effect - think something like including the header or footer of a page. With the example above it seems to be OK to use cfmodule. Depending on your point of view perhaps better due to scoping. These days however I can't imagine that cfmodule would need to be used that often when you have cfimport and just use cf_xxxx to call the custom tag (or prefix:xxxx with cfimport).

@justinmclean
Copy link
Contributor

@bardware
Copy link
Author

I understand your point. Thanks for explaining.

ryaneberly added a commit that referenced this issue May 2, 2016
reverted jdom back to 1.x.  updated jerico parser to 3.4
@ryaneberly ryaneberly mentioned this issue Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants