#339

fix local false positive
cflint · Jul 19, 2017 · ffd72f2 · ffd72f2
1 parent c86009f
commit ffd72f2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/main/java/com/cflint/plugins/core/UnusedLocalVarChecker.java b/src/main/java/com/cflint/plugins/core/UnusedLocalVarChecker.java
@@ -53,7 +53,9 @@ public void expression(final CFExpression expression, final Context context, fin
         } else if (expression instanceof CFVarDeclExpression) {
             final String name = ((CFVarDeclExpression) expression).getName();
             final int lineNo = expression.getLine() + context.startLine() - 1;
-            addLocalVariable(name, lineNo);
+            if(!scopes.isCFScoped(name)){
+                addLocalVariable(name, lineNo);
+            }
         } else if (expression instanceof CFIdentifier) {
             final String name = ((CFIdentifier) expression).getName();
             if(name != null){

diff --git a/src/test/resources/com/cflint/tests/UnusedVariable/local_339.cfc b/src/test/resources/com/cflint/tests/UnusedVariable/local_339.cfc
@@ -0,0 +1,6 @@
+<cfcomponent>
+	<cffunction name="foo">
+		<cfset var local = {}>
+		<cfset local.stEditor = 123>
+	</cffunction>
+</cfcomponent>
diff --git a/src/test/resources/com/cflint/tests/UnusedVariable/local_339.expected.txt b/src/test/resources/com/cflint/tests/UnusedVariable/local_339.expected.txt
@@ -0,0 +1,5 @@
+[ {
+  "totalfiles" : 0
+}, {
+  "totalsize" : 0
+} ]