Mypy Integration and Type Annotations Enhancement #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1035 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 29 29
Lines 7153 7155 +2
=======================================
+ Hits 6300 6302 +2
Misses 853 853 ☔ View full report in Codecov by Sentry. |
Donaim
force-pushed
the
improve-type-checking
branch
from
459a895 to
46c2a49
Compare
Donaim
force-pushed
the
improve-type-checking
branch
from
46c2a49 to
8d47f31
Compare
Donaim
force-pushed
the
improve-type-checking
branch
from
f71c686 to
bbdb716
Compare
* consensus_aligner.py * report_amino.py * project_config.py They are all imported by Contig stitcher.
Donaim
force-pushed
the
improve-type-checking
branch
from
e386e19 to
3df103a
Compare
Donaim
force-pushed
the
improve-type-checking
branch
from
6c9542d to
1b8b30b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces Mypy type checking in the CI workflow to enhance code quality and robustness. Type annotations are added to
consensus_aligner.py,report_amino.py, andproject_config.py. A.mypy.inifile is added for Mypy configuration and relevant dependencies are included inrequirements-dev.txt. The changes aim to catch type-related errors early and maintain clear function interfaces.