-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: added text allowing "Z" for timezone offset. #586
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've addressed everything.
@@ -330,7 +330,7 @@ variables: | |||
ppn:cell_methods = "time: sum"; | |||
double time(time); | |||
time:long_name = "time"; | |||
time:units = "h since 1998-4-19 6:0:0"; | |||
time:units = "h since 1998-4-19 6:0:0 Z"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit - just seen the above conversion on this, so I retract the comment!
I found that the lack of space before Z
is required: "If the time is in UTCm add a Z directly after the time without a space." (https://en.wikipedia.org/wiki/ISO_8601#Coordinated_Universal_Time_(UTC))
OK -- I think this is in good shape. But I'm not sure what to do about:
Also: I finally found a way to look at the rendered doc. Using "Z" as the placeholder, while also allowing the string "Z" is a bit confusing: "or the letter "Z" are allowed in Z, not time zone names or acronyms." the second I'm not going to change that now, but maybe in the future? |
Thanks, Chris. We don't need a change to the conventions doc for this PR, so "N/A" or equivalent. The issue should be added to the list for the working version in the revision history - however, the heading is not there. I think we first need a new working version to be created for CF 1.13, before this PR can be merged into it. David intends to do that. |
See issue #584 for discussion of these changes.
NOTE: I think there's consensus about allowing "Z" as a timezone offset (already allowed by udunits)
It was decided to include a "proper" recommendation that a zero or Z be included for UTC times -- but some text was added saying it is a good idea in some cases.
Release checklist
** Will do this once we've all agreed **
cf-conventions.adoc
? Add in two places: on line 3 and under.Additional Authors
inAbout the authors
.cf-conventions.adoc
up to date? Versioning inspired by SemVer.history.adoc
up to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then,
main
always is a draft for the next version.