Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parallel authentications #173

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Add support for parallel authentications #173

merged 1 commit into from
Apr 13, 2020

Conversation

ventsislav-georgiev
Copy link
Contributor

@ventsislav-georgiev ventsislav-georgiev commented Mar 2, 2020 •
edited
Loading

Login to multiple locations by running the cli in parallel.
Fixes an issue where concurrent read and writes of the config end up breaking it or overwriting credentials.

Changes:

  • Use a filelock lib for cross-process locking of read/write config operations

@ventsislav-georgiev
Add support for multi-process login
501620c 
Login to multiple locations by running the login command in parallel.
Fixes an issue where concurrent read and writes of the config end up breaking it or overwriting credentials.

Changes:
* Use a filelock lib for cross-process locking of read/write config operations
@ventsislav-georgiev ventsislav-georgiev changed the title Add support for multi-process login Add support for parallel authentications Mar 2, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 48.941% when pulling 501620c on ventsislav-georgiev:multi-process into b5ee247 on cevoaustralia:master.

@ventsislav-georgiev
Copy link
Contributor Author

@stevemac007 This is a minor change (check it with whitespace diff disable e.g. &w=1), with a single small dependency install. The coverage is falling because these existing branches do not have tests. My change just adds an inter-process locking via new file. It shouldn't have any affect to the ppl which do not span multiple processes and fix the concurrency issues for those that do.

@gprodanov
Copy link

I could really make use of this feature.

stevemac007
stevemac007 approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@stevemac007 stevemac007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@stevemac007 stevemac007 merged commit db3a92d into cevoaustralia:master Apr 13, 2020
@ventsislav-georgiev ventsislav-georgiev deleted the multi-process branch September 14, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemac007 stevemac007 stevemac007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ventsislav-georgiev @coveralls @gprodanov @stevemac007