Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bgresponse copy to mention logged out state #157

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Update bgresponse copy to mention logged out state #157

merged 1 commit into from
Nov 17, 2019

Conversation

ruimarinho
Copy link
Contributor

Make it clear that document.bg.invoke() needs to run on Google's authentication page, not AWS, i.e., the user needs to be logged out or using an incognito browser session.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.127% when pulling 75cda2f on ruimarinho:support/bgresponse-improved-copy into 76c9d5f on cevoaustralia:master.

stevemac007
stevemac007 approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@stevemac007 stevemac007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

@stevemac007 stevemac007 merged commit 0cdf40c into cevoaustralia:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemac007 stevemac007 stevemac007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruimarinho @coveralls @stevemac007