-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No credential exports printed when using docker. #96
Comments
@jgissend10 I think you are right. It seems in
will always be true so it would never print. two options I can think of is either you can print it always. or you print based on a parameter. I find the latter more secure as I m not sure if we should just print the keys in the terminal. Thoughts..? |
I'd prefer a parameter and to just replace the else with 'if parameter:'
that way I can print it out even if we're writing the config to the client.
…On Thu, Aug 16, 2018, 04:17 wcharaka ***@***.***> wrote:
@jgissend10 <https://github.com/jgissend10> I think you are right. It
seems in Configuration the self.profile is defaults to sts hence
if config.profile:
config.write(amazon_client)
else:
amazon_client.print_export_line()
will always be true so it would never be true. two options I can think of
is either you can print it always. or you print based on a parameter. I
find the latter more secure as I m not sure if we should just print the
keys in the terminal. Thoughts..?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAj-vqxTL3iZWgk-qC9-1S6423u3hT0Tks5uRSqYgaJpZM4V4u5n>
.
|
Agree, lets add an option to print the credentials so you have the option to use this no matter which way you use it. |
Any update on this? |
@wcharaka are you still looking at this one, otherwise I'm happy to pick this up and get it working agin. |
@stevemac007 I m on it.. |
This has been fixed and released. |
The credential exports aren't printed when using docker. It seems the config.profile has a value no matter what and the else that should print them is never reached.
The text was updated successfully, but these errors were encountered: