Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No credential exports printed when using docker. #96

Closed
jtszalay opened this issue Aug 10, 2018 · 7 comments
Closed

No credential exports printed when using docker. #96

jtszalay opened this issue Aug 10, 2018 · 7 comments
Assignees

Comments

@jtszalay
Copy link

The credential exports aren't printed when using docker. It seems the config.profile has a value no matter what and the else that should print them is never reached.

@wcharaka
Copy link
Contributor

wcharaka commented Aug 16, 2018

@jgissend10 I think you are right. It seems in Configuration the self.profile is defaults to sts hence

if config.profile:
        config.write(amazon_client)
else:
        amazon_client.print_export_line()

will always be true so it would never print. two options I can think of is either you can print it always. or you print based on a parameter. I find the latter more secure as I m not sure if we should just print the keys in the terminal. Thoughts..?

@jtszalay
Copy link
Author

jtszalay commented Aug 16, 2018 via email

@stevemac007
Copy link
Contributor

Agree, lets add an option to print the credentials so you have the option to use this no matter which way you use it.

@jtszalay
Copy link
Author

Any update on this?

@stevemac007
Copy link
Contributor

@wcharaka are you still looking at this one, otherwise I'm happy to pick this up and get it working agin.

@wcharaka
Copy link
Contributor

@stevemac007 I m on it..

@wcharaka
Copy link
Contributor

wcharaka commented Nov 6, 2018

This has been fixed and released.

@wcharaka wcharaka closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants