This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
upgrade services for helm 3 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade the services to fix this cetic/fadi#84
|
ci/circleci: build — Your tests failed on CircleCI failed because when this PR was created Tsaas wasn't updated to V0.1.3 yet. |
|
@AyadiAmen it should be available now. |
|
Thanks for the modifications, @AyadiAmen! By the way, I think it's the good moment to deprecate pgadmin. Could you remove pgadmin from the values.yaml / README.md / requirements.yaml and set adminer to |
|
See issue cetic/fadi#92 |
|
@alexnuttinck yes sure |
deleting pgadmin and making adminer enabled by default
update NOTES.txt after removing pgadmin
|
@alexnuttinck thanks ! |
This was referenced Jan 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade the services to fix this cetic/fadi#84
What this PR does / why we need it:
Which issue this PR fixes
fix for cetic/fadi#84
update services to work with helm3
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]