Add 2 basic unit tests

[bnavigator]

Closes #136

These tests are very basic. They just check that the returned string is really a file and contains the PEM certificate header.

The workflow runs with pytest, but you could also use native python -m unittest.

Further work could use openssl or the Python module Cryptography to check for valid CA certificates.

[bnavigator]

See https://github.com/bnavigator/python-certifi/runs/991003207 how this will look like in Github Actions

[mcepl]

Would you be able to make those tests a little bit more robust, so they would work even with the modified OpenSUSE package? https://build.opensuse.org/package/show/home:mcepl:branches:devel:languages:python/python-certifi

[bnavigator]

The test fail is legit. If there is no -----BEGIN CERTIFICATE----- in /etc/ssl/ca-bundle.pem, something is wrong:

greiner@greinerT450s:~/src/osc/home:mcepl:branches:devel:languages:python/python-certifi/ > osc shell
abuild@greinerT450s:~> cat /etc/ssl/ca-bundle.pem
#
# automatically created by /usr/lib/ca-certificates/update.d/99certbundle.run. Do not edit!
#
# Use of this file is deprecated and should only be used as last
# resort by applications that do not support p11-kit or reading /etc/ssl/certs.
# You should avoid hardcoding any paths in applications anyways though. Use
# functions that know the operating system defaults instead:
#
# - openssl: SSL_CTX_set_default_verify_paths()
# - gnutls: gnutls_certificate_set_x509_system_trust(cred)
#
abuild@greinerT450s:~> rpm -qf /etc/ssl/ca-bundle.pem
ca-certificates-2+git20201002.34daf7f-1.1.noarch
abuild@greinerT450s:~> logout
greiner@greinerT450s:~/src/osc/home:mcepl:branches:devel:languages:python/python-certifi/ > head -n 15 /etc/ssl/ca-bundle.pem
#
# automatically created by /usr/lib/ca-certificates/update.d/99certbundle.run. Do not edit!
#
# Use of this file is deprecated and should only be used as last
# resort by applications that do not support p11-kit or reading /etc/ssl/certs.
# You should avoid hardcoding any paths in applications anyways though. Use
# functions that know the operating system defaults instead:
#
# - openssl: SSL_CTX_set_default_verify_paths()
# - gnutls: gnutls_certificate_set_x509_system_trust(cred)
#
-----BEGIN CERTIFICATE-----
MIIH0zCCBbugAwIBAgIIXsO3pkN/pOAwDQYJKoZIhvcNAQEFBQAwQjESMBAGA1UE
AwwJQUNDVlJBSVoxMRAwDgYDVQQLDAdQS0lBQ0NWMQ0wCwYDVQQKDARBQ0NWMQsw
CQYDVQQGEwJFUzAeFw0xMTA1MDUwOTM3MzdaFw0zMDEyMzEwOTM3MzdaMEIxEjAQ
greiner@greinerT450s:~/src/osc/home:mcepl:branches:devel:languages:python/python-certifi/ > rpm -qf /etc/ssl/ca-bundle.pem
ca-certificates-2+git20201002.34daf7f-1.1.noarch

[bnavigator]

Note also the empty /etc/ssl/certs/ in the obs environment.

[bnavigator]

https://build.opensuse.org/request/show/850705

It's highly openSUSE specific

[mcepl]

I have slightly improved version of the test script.

test_certifi.py

[alex]

@bnavigator Thanks for taking the time to work on this, and sorry we've been slow to review. I'm going to make a branch off your branch and try to get this merged today! Thanks again.

[mcepl]

@bnavigator Thanks for taking the time to work on this, and sorry we've been slow to review. I'm going to make a branch off your branch and try to get this merged today! Thanks again.

See my version of the test script (don’t bother with the authorship of the patch, I release it to public domain).

[bnavigator]

Sure, no problem.