Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx ingress chart name is now ingress-nginx #421

Merged

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Feb 3, 2021

Fixes #416

Nginx Helm chart has changed name nginx-ingress -> ingress-nginx. Updates the instructions and command outputs in Securing NGINX-ingress tutorial instructions to reflect that.

#399 already did some of that, but there were a few more nginx-ingresses hidden in the page.

Signed-off-by: irbekrm [email protected]

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Feb 3, 2021
@jetstack-bot jetstack-bot requested a review from munnerz February 3, 2021 15:00
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2021
@jakexks
Copy link
Member

jakexks commented Feb 4, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@jetstack-bot jetstack-bot merged commit 5101f65 into cert-manager:master Feb 4, 2021
@irbekrm irbekrm deleted the 414_ingress_chart_name_change branch February 4, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update instructions in the Securing NGINX-ingress' tutorial
3 participants