-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cert-manager installation using argocd #1350
Conversation
Signed-off-by: shahkv95 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: shahkv95 <[email protected]>
Signed-off-by: shahkv95 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shahkv95
This looks good. I left a few suggestions and enabled the automated tests.
There some spell check errors for which I have suggested some changes.
- Optional: A GitOps repository connected with ArgoCD: [setup guide](https://argo-cd.readthedocs.io/en/stable/user-guide/private-repositories/) | ||
|
||
### Setting up cert-manager | ||
1. Create an ArgoCD Application manifest file with the provided configuration to set up cert-manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Create an ArgoCD Application manifest file with the provided configuration to set up cert-manager. | |
1. Create an [ArgoCD Application manifest file](link-to-reference-documentation) with the provided configuration to set up cert-manager. |
It will be useful to link to the documentation so that the reader can learn about the fields of this custom resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wallrj this is not my code/fix BUT i'm currently affected by this.
I will pull this branch and make the suggested edits after my comments below are accepted or better suggestions are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't have permission to push to @shahkv95 's branch, so I've created my own.
- CreateNamespace=true | ||
``` | ||
2. Commit the manifest file and sync the changes in ArgoCD. If a GitOps repository is not set up, use `kubectl apply -f <above-file-path>` to apply the manifest [installation guide for kubectl](https://kubernetes.io/docs/tasks/tools/#kubectl). | ||
3. ArgoCD will synchronize the `DESIRED MANIFEST` and deploy cert-manager on Kubernetes based on the provided configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show the reader how they can check the status of the installation.
And explain what the reader should look for to know that the installation has succeeded.
what's going on here ? |
@shahkv95 I don't have permission to push to your branch, so I've pushed your commits to my own branch, rebased and addressed my latest code review comments there: I'll close this PR and we can continue the work there. |
Preview: https://deploy-preview-1350--cert-manager-website.netlify.app/docs/installation/continuous-deployment-and-gitops/#using-argocd
Linked issue: cert-manager/cert-manager#4114