Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linters #102

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Fix linters #102

merged 4 commits into from
Apr 3, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Mar 28, 2024 •
edited
Loading

Reduces the list of ignored linters by fixing the go code.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 28, 2024
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2024
inteon added 4 commits April 3, 2024 15:33
@inteon
fix tenv linter
929edb6 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gci linter
569c044 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix unparam linter
74183b2 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
fix gocritic linter
2cf3e86 
Signed-off-by: Tim Ramlot <[email protected]>
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@inteon
Copy link
Member Author

inteon commented Apr 3, 2024

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@jetstack-bot jetstack-bot merged commit e9d8b94 into cert-manager:main Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @ThatsMrTalbot @jetstack-bot