Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumps for CVE-2023-44487 & CVE-2023-39325 #48

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

SgtCoDFish
Copy link
Member

Also bumps base images and our version for a release.

Also changes to use go install instead of go build for dependencies. I still dislike tools.go generally (e.g. trivy still reports a vuln in our go.mod in the docker lib which is like 4 tool dependencies deep) - but I think go build + tools.go is actively harmful while go install + tools.go is less bad!

this means we don't have to worry about differing dependency versions
in our tool dependencies, so they won't be built with dependencies they
weren't designed for

Signed-off-by: Ashley Davis <[email protected]>
also bumps our distroless version to debian 12 and bumps our alpine version,
alongside other BAU version bumps

Signed-off-by: Ashley Davis <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2023
@inteon
Copy link
Member

inteon commented Nov 16, 2023

Thank you for making these improvements.
We probably want to remove tools.go in the future.
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@inteon
Copy link
Member

inteon commented Nov 16, 2023

/test pull-cert-manager-csi-driver-spiffe-verify

@jetstack-bot jetstack-bot merged commit b55a042 into cert-manager:main Nov 16, 2023
@SgtCoDFish SgtCoDFish deleted the bumps branch November 16, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants