Ensure bindir exists before running certain commands #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
|
/test pull-cert-manager-csi-driver-spiffe-e2e |
1 similar comment
|
/test pull-cert-manager-csi-driver-spiffe-e2e |
|
@SgtCoDFish see #47 |
Ouch, I hope nobody else got hit by that! I'll review that when it's passing |
No, it's just the way that the CertificateRequest for this e2e test is generated which is wrong. |
Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
bindirdep
branch
from
1d6ccbf
to
472419a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents confusion on an initial checkout