Make data dir configurable #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equivalent to https://github.com/cert-manager/csi-driver/pull/73/files this allows a different hostPath to be used, working around an issue with system-tmpfiles-clean task. We were running into this issue with EKS managed nodes which seem to cleanup /tmp every now and then. Signed-off-by: Daniel Bornkessel <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
jetstack-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks a lot and sorry for not reacting in the other PR: I was kind of offline. |
|
Absolutely no need to apologise; thank you for the contribution ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Thanks @kesselborn for the contribution! This PR cherry-picks the commit from #32 and fixes it to pass CI, so that we can proceed with a release which includes that fix.