Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing --csi-driver-name option to daemonset #24

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add missing --csi-driver-name option to daemonset #24

merged 1 commit into from
Apr 4, 2023

Conversation

kesselborn
Copy link
Contributor

This was missing in the daemonset but present in the deployment with the confusing effect that the csidriver was listed when listing the csidrivers but reported as missing, when being useD

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2023
@jetstack-bot
Copy link
Contributor

Hi @kesselborn. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2023
@SgtCoDFish
Copy link
Member

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2023
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2023
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 24, 2023
@kesselborn
Add missing --csi-driver-name option to daemonset
bb99002 
This was missing in the daemonset but present in the deployment with the
confusing effect that the csidriver was listed when listing the
csidrivers but reported as missing, when being useD

Signed-off-by: Daniel Bornkessel <[email protected]>
@kesselborn
Copy link
Contributor Author

@SgtCoDFish I removed the patch-bump in the Chart.yaml file ... is that what is missing to get this merged?

SgtCoDFish
SgtCoDFish approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, yeah, that was the only thing missing. Looks like this arg should definitely be added!

Appreciate the contribution! I'll try to look into getting a release done with this change, but it won't be straight away because there's a lot going on right now. Could be after KubeCon EU!

Thanks again!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kesselborn, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@jetstack-bot jetstack-bot merged commit 022143c into cert-manager:main Apr 4, 2023
@SgtCoDFish
Copy link
Member

This is now released in 0.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselborn @jetstack-bot @SgtCoDFish