Increase timeouts for camanager test #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
These timeouts are incredibly aggressive and caused test flakes on my machine when testing unrelated changes. NB: I'm not 100% confident that these tests are really useful, but rather than ripping them out it seems easier to bump the timeouts Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
timeout-bump
branch
from
0e4fefe to
4d3adaf
Compare
|
Thanks @SgtCoDFish, let's bump the timeouts so we are not hindered in development. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
cert-manager-prow
bot
merged commit abc426a
into
cert-manager:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These timeouts are incredibly aggressive and caused test flakes on my machine when testing unrelated changes.
NB: I'm not 100% confident that these tests are really useful, but rather than ripping them out it seems easier to bump the timeouts