Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to operator-sdk 1.18.1 #64

Closed
wants to merge 2 commits into from

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Mar 29, 2022

This brings some new bundle validation checks which might be useful.

I've had to work around a new bug in operator-sdk 1.18 which makes it incompatible with non-operator-sdk generated projects.

wallrj added 2 commits March 29, 2022 16:09
Add a hack to work around a new inflexible requirement for there to be a
Deployment having label "control-plane: controller-manager" with a container
called "manager".

operator-framework/operator-sdk#5574

Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@jetstack-bot
Copy link
Contributor

@wallrj: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj mentioned this pull request Apr 28, 2022
@wallrj
Copy link
Member Author

wallrj commented Apr 28, 2022

The bug described in the description which required a work around has been fixed in 1.19.1

@wallrj wallrj closed this Apr 28, 2022
@wallrj wallrj deleted the operator-sdk-1.18.1 branch April 28, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants