Scipts to package cert-manager as OLM bundles on OperatorHub #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
jetstack-bot
added
the
size/XXL
Closed
This was
linked to
issues
Jun 21, 2021
Closed
Signed-off-by: Richard Wall <[email protected]>
As per the PR template: https://github.com/operator-framework/community-operators/blob/master/docs/pull_request_template.md Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
27 tasks
Signed-off-by: Richard Wall <[email protected]>
wallrj
commented
Jun 22, 2021
|
|
||
| * Add the new version of cert-manager to the `CERT_MANAGER_VERSIONS` list at the top of the `Makefile` | ||
| * Run `make catalog-build` to generate / update all the bundle files in `./github.com/operator-framework/community-operators/` | ||
| * [Preview the generated clusterserviceversion file on OperatorHub ](https://operatorhub.io/preview) |
wallrj
commented
Jun 23, 2021
| "--tls-cert-file=/tmp/k8s-webhook-server/serving-certs/tls.crt", | ||
| "--tls-private-key-file=/tmp/k8s-webhook-server/serving-certs/tls.key", | ||
| ]) | ||
| container["args"] = args |
There was a problem hiding this comment.
There are two issues addressed here:
- OpenShift / OLM creates its own webhook certificates and injects them into the webhook config and mounts them into the webhook pod. So here I configure the webhook server with the paths to the OLM mounted key pair files.
- It also overrides the webhook service name with a
-servicesuffix, which is why I changed the--dynamic-serving-dns-namesargument, but actually that argument can probably be removed altogether.
This may fix cert-manager/cert-manager#4055.
SgtCoDFish
requested changes
Jun 23, 2021
github.com/operator-framework/community-operators/global-csv-config.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Richard Wall <[email protected]>
…onfig.yaml Co-authored-by: Ashley Davis <[email protected]> Signed-off-by: Richard Wall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25, #24, #21, #23
It's taken a while to figure out all the tools, but here is a Makefile which wraps the
operator-sdkCLI to generatebundlefiles for multiple versions of cert-manager.There a couple of other Python scripts to first reduce the size of CRDs so that the bundle is small enough to be extracted to a configmap by OLM.
This is a work around for operator-framework/operator-lifecycle-manager#1523
Adapted from https://raw.githubusercontent.com/kubevirt/hyperconverged-cluster-operator/c6b425961feb0f350655ccfa7401336b30de66ab/hack/strip_old_descriptions.py in kubevirt/hyperconverged-cluster-operator#1396
There is another script which automates the process of filling in various fields in the clusterserviceversion (CSV) file, such as encoding a logo and adding various meta information.
Finally, the Makefile includes some targets to help with testing the bundles in a local Kind cluster, as described in https://github.com/operator-framework/community-operators/blob/master/docs/testing-operators.md
TODO:
bundle/cert-manager-operatorcontent from this repocertmanagers.operator.cert-manager.iowhich I think may be a mistake