-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixtures: files and insert-or-replace mode #2039
Comments
yes when replacing or updating a file with Easy fix: is to just update metadata for this records..and skip files leaving them in their |
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]>
If we update only the metadata, then we would not cover the original scenario described above. It is possible that the record metadata has changed, or the file information such as some file size has changed, or some new files were added... We need to have an easy way to update records in all these scenarios. |
@tiborsimko the only and easy way to do this now is to remove bucket and files and recreate them again when someone asks for update . Is that ok for you ? |
@ioannistsanaktsidis Yes, that would be perfect, since we always do a full "replace" operation, and never a partial "update". |
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
* Closes cernopendata#2039. Signed-off-by: Ioannis Tsanaktsidis <[email protected]> Co-authored-by: Pamfilos Fokianos <[email protected]>
It seems we have a problem with files when using fixtures with
--mode insert-or-replace
. To be tested locally and fixed.Here's one scenario to test:
--skip-files --mode-insert
. (so no files)--mode insert-or-replace
. (so with files)Might be good to test other combinations of (1) initial record state (with or without files); and (2) update mode (replace or insert-or-replace, with or without files).
The text was updated successfully, but these errors were encountered: