Fix Default Port Value #202
Conversation
emilyrohrbough
requested review from
bjankord,
JakeLaCombe,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
Dockerfile
Outdated
| @@ -2,4 +2,4 @@ | |||
| FROM cerner/terra-node | |||
|
|
|||
| # run the server | |||
| CMD ["npm", "run", "start"] | |||
| CMD ["npm", "run", "start", "--", "--port", "8080"] | |||
There was a problem hiding this comment.
This is temporary until we get a clean release right?
There was a problem hiding this comment.
Yes should be. @ryanthemanuel When do we push the 'latest' tagged docker image?
There was a problem hiding this comment.
Travis ci does it. https://github.com/cerner/terra-toolkit/blob/master/.travis.yml#L58
There was a problem hiding this comment.
Though, i'd be remiss if i didn't point out that if we were testing against this version and not the previously released version, this issue wouldn't have been released.
There was a problem hiding this comment.
Also i'm pretty sure my previous comment was wrong. Please disregard. :)
|
+1 for commit messages |
|
Can we test this branch against terra-core? |
Generated by 🚫 dangerJS |
|
After spending way too log going down a lovely rabbit hole with @mjhenkes , it was discovered
Removing the package-lock did the trick to clean this up. |
Summary
Default port value is returning NaN.