Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lightweight account home page #23

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

JammingBen
Copy link

@JammingBen JammingBen commented Oct 18, 2023

Adds a landing page for lightweight user accounts, similar as it's done in owncloud/web@9c4ec26. It checks for the user role, which is the indicator for lightweight users in our (owncloud) case: user.role?.name === 'user-light'

image

Works towards owncloud/web#9381

@diocas
Copy link
Contributor

diocas commented Oct 30, 2023

Thanks for the PR @JammingBen (I missed it, sorry for the delay).

Just a point to confirm:

  • when you login you are redirected to homeFolder. But when you are a lightweight account, your homeFolder needs to change to the page you contributed. Would this be possible?

@JammingBen
Copy link
Author

when you login you are redirected to homeFolder. But when you are a lightweight account, your homeFolder needs to change to the page you contributed. Would this be possible?

What exactly is the page you contributed and how to retrieve it? In general, the nav item can also have a handler callback on click that e.g. retrieves the page and then routes to it. Or does it have a fixed path?

@dschmidt
Copy link

Thanks for the PR @JammingBen (I missed it, sorry for the delay).

Just a point to confirm:

  • when you login you are redirected to homeFolder. But when you are a lightweight account, your homeFolder needs to change to the page you contributed. Would this be possible?

Have you tested this PR?
If your user has the light-user role, you see the welcome page after login and not personal space.

@elizavetaRa
Copy link
Contributor

elizavetaRa commented Nov 1, 2023

In your current latest there is this in response: <user-type> primary </user-type>
Why use use.role and not user-type?

@dschmidt
Copy link

dschmidt commented Nov 1, 2023

user-type is not a concept in our product, afaict. So we used something we have. In your extension you are obviously free to do whatever

@diocas
Copy link
Contributor

diocas commented Nov 3, 2023

@dschmidt did not try yet and I missed the code that does that... Sorry, everything should be fine then.

@diocas diocas merged commit 3a27e54 into cernbox:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants