fix(form): handle exceptions in form #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamfilos
reviewed
Nov 12, 2024
src/forms/Form.jsx
Outdated
| issues. | ||
| </li> | ||
| <li> | ||
| When you get this error, you usually want to be looking at |
There was a problem hiding this comment.
- since we aim for external use, lets make the error element customizable and passed through the context provider (with a default as you have it).
- in the default we should also update the text to mention that it can also be a uiSchema issue (e.g widget/field non existant, etc)
There was a problem hiding this comment.
In that case I think we should allow providing a custom ErrorBoundary directly, this way it's even more flexible (you can provide an antd error boundary with a different message or a fully custom one with your own logic, and otherwise we use the default).
* Add default error boundary for form * Allow users to provide a custom error boundary
miguelgrc
force-pushed
the
form-error-boundary
branch
from
0e2ab21 to
8e09624
Compare
pamfilos
approved these changes
Nov 13, 2024
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error boundaries to catch errors e.g. with invalid JSON schemas in FormuleForm and display them properly