Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add electron-store to manage settings #609

Merged
merged 5 commits into from
Oct 21, 2022
Merged

chore: add electron-store to manage settings #609

merged 5 commits into from
Oct 21, 2022

Conversation

dubisdev
Copy link
Contributor

With this PR we get:

  • Type checking for the settings (using the settings schema and validation)
  • A powerful tool to migrate settings
  • Remove boilerplate (we don't handle the writing to filesystem)

fix #606

@dubisdev dubisdev requested review from ogustavo-pereira and removed request for ogustavo-pereira October 5, 2022 06:21
ogustavo-pereira
ogustavo-pereira approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@ogustavo-pereira ogustavo-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good I liked it a lot congratulations

@ogustavo-pereira ogustavo-pereira merged commit e62fb94 into master Oct 21, 2022
@ogustavo-pereira ogustavo-pereira deleted the chore-add-electron-store branch October 21, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogustavo-pereira ogustavo-pereira ogustavo-pereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: migrate to settings code to electron-store
2 participants
@dubisdev @ogustavo-pereira