-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-16): migrate to new react version #604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Hi @oguhpereira As this is going to be a big PR, it would be nice if you could start reviewing now. |
ogustavo-pereira
changed the title
[WIP] chore: refactor to functional components
[WIP] refactor(react-16): refactor to functional components
Sep 19, 2022
I fixed the error with Selecting settings. Seems like they changed the API and I didn't saw the change for |
The error with react-virtualized is also fixed. I'll update some of the docs to make examples work with these breaking changes. |
dubisdev
changed the title
[WIP] refactor(react-16): refactor to functional components
perf(react-16): migrate to new react version
Sep 20, 2022
ogustavo-pereira
changed the title
perf(react-16): migrate to new react version
refactor(react-16): migrate to new react version
Sep 20, 2022
ogustavo-pereira
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating to react 16 (the goal is to migrate to the last React version).
DONE
BROKEN(Already fixed)Known issues:
React virtualized is not updating the results list and it is empty some times.
View Image
Select settings are not showing the value (but it still works)
View Image
(search engine should appear but is missing)
Related PRs
We need to update related packages as
cerebro-ui
Breaking changes