Workaround for outdated NodObjC dependency #451
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to illustrate what is preventing node 9 support (#426).
It seems that the latest version for the package nodobjc published on npm is more than 2 years old. Same goes for some of its dependencies that are still using native methods flagged as deprecated for a while now but finally got removed from node / v8 engine.
Thankfully the package sources on github are fresh enough so I could build all depencies using node 9 and cerebro seems to be working just fine. As shown in this PR the only tweaks required was to fetch nodobjc from github as well to make nodobjc fetch ffi from github too (hence my fork on nodobjc).
Maybe @TooTallNate have good reasons to not publish from the latest source (maybe lots of people without packege locks?), but since this project requires node 8+ this update isn't a breaking change so we could simply fetch these dependencies directly from github in case these npm packages aren't going to get updated anytime soon.
Either way I just wanted to point what I think is the source of this issue.
@maximbaz let me if that fixes this on your env too.