cleanups and dependency updates #438
Conversation
* fix missing deps * add a `yarn clean` command using rimraf
…omes with the builder.
* react-addons-css-transition-group is now react-transtion-group * react-virtualized was updated to the latest version and the code now uses their List component * node engine is now >=8.0
|
I wonder if it is possible to make Travis build Cerebro not only against LTS node (which is 8 now), but also against the current version (which is 9 now)? This would have prevented #426, which blocks upgrading cerebro on the entire Arch Linux distribution. |
|
Yes, Travis supports a matrix mode, like so https://github.com/sindresorhus/clipboardy/blob/master/.travis.yml |
|
Hey, @Stanzilla! Thanks for this great job! For me everything looks good but I found one bug, I think it is related to new version of react-virtualized. Issue is: if I hold arrow down in current version of Cerebro I properly see list of results, but after update it is hidden after few results. Before: http://recordit.co/Zd4UL0mF7l Would be great if you can fix it before I merge this PR |
|
Yeah it is and I think it might be either using the wrong component or need a newer react version, I sadly don't know too much about that. Would be awesome if you could help? |
|
@Stanzilla ок, I'll try to find the reason a bit later |
|
added one more commit based on https://github.com/bvaughn/react-virtualized/blob/master/docs/creatingAnInfiniteLoadingList.md it's a WIP though, maybe you can finish it with that. |
|
@KELiON haven't had any time to take a look yet? :) |
|
@KELiON friendly ping :) |
yarn cleancommand using rimraf