Fix lint errors

cerebroapp · Mar 10, 2017 · ac89596 · ac89596
1 parent ce3f8f5
commit ac89596
Show file tree

Hide file tree

Showing 9 changed files with 61 additions and 22 deletions.
diff --git a/app/lib/plugins/index.js b/app/lib/plugins/index.js
@@ -32,4 +32,4 @@ export const ensureFiles = () => {
 }
 
 export const client = npm(pluginsPath)
-export { default as addSettings } from './settings' 
+export { default as addSettings } from './settings'
diff --git a/app/lib/plugins/settings.js b/app/lib/plugins/settings.js
@@ -15,7 +15,7 @@ const isValidSetting = setting => {
     return false
   }
 
-  if (type == 'option') {
+  if (type === 'option') {
     return Array.isArray(options) && options.length
   }
 
@@ -35,6 +35,7 @@ export default ({ settings }, base) => {
       return
     }
 
+    // eslint-disable-next-line no-unused-vars
     const { value, ...pluginSetting } = pluginSettings[key] || {}
 
     if (!isEqual(setting, pluginSetting)) {

diff --git a/app/main/actions/search.js b/app/main/actions/search.js
@@ -41,7 +41,9 @@ const eachPlugin = (term, display) => {
   Object.keys(plugins).forEach(name => {
     const settings = externalSettings[name]
     if (settings) {
-      Object.keys(settings).forEach(key => settings[key] = settings[key].value)
+      Object.keys(settings).forEach(key => {
+        settings[key] = settings[key].value
+      })
     }
 
     try {

diff --git a/app/main/plugins/core/cerebro/settings/Settings/components/checkbox.js b/app/main/plugins/core/cerebro/settings/Settings/components/checkbox.js
@@ -1,7 +1,7 @@
-import React from 'react'
+import React, { PropTypes } from 'react'
 import styles from '../styles.css'
 
-export default (props) => (
+const Checkbox = (props) => (
   <div className={styles.item}>
     <div className={styles.itemValueWithoutLabel}>
       <label>
@@ -16,3 +16,11 @@ export default (props) => (
     </div>
   </div>
 )
+
+Checkbox.propTypes = {
+  value: PropTypes.any,
+  onChange: PropTypes.func.isRequired,
+  description: PropTypes.string,
+}
+
+export default Checkbox
diff --git a/app/main/plugins/core/cerebro/settings/Settings/components/input.js b/app/main/plugins/core/cerebro/settings/Settings/components/input.js
@@ -1,8 +1,8 @@
-import React from 'react'
+import React, { PropTypes } from 'react'
 import styles from '../styles.css'
 import hotkeyStyles from '../Hotkey/styles.css'
 
-export default (props) => (
+const Input = (props) => (
   <div className={styles.item}>
     <label className={styles.label}>{props.label}:</label>
     <div className={styles.itemValue}>
@@ -18,3 +18,13 @@ export default (props) => (
     </div>
   </div>
 )
+
+Input.propTypes = {
+  inputType: PropTypes.string.isRequired,
+  label: PropTypes.string,
+  value: PropTypes.any,
+  onChange: PropTypes.func.isRequired,
+  description: PropTypes.string,
+}
+
+export default Input
diff --git a/app/main/plugins/core/cerebro/settings/Settings/components/options.js b/app/main/plugins/core/cerebro/settings/Settings/components/options.js
@@ -1,8 +1,8 @@
-import React from 'react'
-import Select, { Creatable } from 'react-select'
+import React, { PropTypes } from 'react'
+import { Creatable } from 'react-select'
 import styles from '../styles.css'
 
-export default (props) => (
+const Options = (props) => (
   <div className={styles.item}>
     <div className={styles.itemValue}>
       <Creatable
@@ -18,3 +18,14 @@ export default (props) => (
     </div>
   </div>
 )
+
+Options.propTypes = {
+  options: PropTypes.array.isRequired,
+  label: PropTypes.string,
+  value: PropTypes.any,
+  onChange: PropTypes.func.isRequired,
+  description: PropTypes.string,
+  multi: PropTypes.bool.isRequired,
+}
+
+export default Options
diff --git a/app/main/plugins/core/cerebro/settings/Settings/components/select.js b/app/main/plugins/core/cerebro/settings/Settings/components/select.js
@@ -1,12 +1,12 @@
-import React from 'react'
-import Select, { Creatable } from 'react-select'
+import React, { PropTypes } from 'react'
+import { Creatable } from 'react-select'
 import styles from '../styles.css'
 
-export default (props) => (
+const Select = (props) => (
   <div className={styles.item}>
     <div className={styles.itemValue}>
       <Creatable
-        multi={true}
+        multi
         value={props.value}
         placeholder={props.label}
         onChange={props.onChange}
@@ -17,3 +17,12 @@ export default (props) => (
     </div>
   </div>
 )
+
+Select.propTypes = {
+  label: PropTypes.string,
+  value: PropTypes.any,
+  onChange: PropTypes.func.isRequired,
+  description: PropTypes.string,
+}
+
+export default Select
diff --git a/app/main/plugins/core/cerebro/settings/Settings/external-settings.js b/app/main/plugins/core/cerebro/settings/Settings/external-settings.js
@@ -1,7 +1,5 @@
 import React, { PropTypes, Component } from 'react'
-import loadThemes from 'lib/loadThemes'
 import styles from './styles.css'
-import hotkeyStyles from './Hotkey/styles.css'
 import { Checkbox, Input, Select, Options } from './components'
 
 export default class ExternalSettings extends Component {
@@ -19,7 +17,7 @@ export default class ExternalSettings extends Component {
     const { type, description } = setting
     const value = setting.value || setting.defaultValue
 
-    if (type == 'bool') {
+    if (type === 'bool') {
       return (
         <Checkbox
           key={label}
@@ -30,7 +28,7 @@ export default class ExternalSettings extends Component {
       )
     }
 
-    if (type == 'array') {
+    if (type === 'array') {
       return (
         <Select
           key={label}
@@ -42,7 +40,7 @@ export default class ExternalSettings extends Component {
       )
     }
 
-    if (type == 'option') {
+    if (type === 'option') {
       const { multi } = setting
       const options = setting.options.map(option => ({ label: option, value: option }))
 
@@ -52,8 +50,8 @@ export default class ExternalSettings extends Component {
           label={label}
           value={value}
           onChange={newValue => {
-            const value = multi ? newValue.map(val => val.value) : newValue.value
-            this.changeSetting(plugin, label, value)
+            const changedValue = multi ? newValue.map(val => val.value) : newValue.value
+            this.changeSetting(plugin, label, changedValue)
           }}
           description={description}
           options={options}

diff --git a/app/main/plugins/externalPlugins.js b/app/main/plugins/externalPlugins.js
@@ -55,7 +55,7 @@ pluginsWatcher.on('addDir', (pluginPath) => {
       console.groupEnd()
       return
     }
-    addSettings(plugin, base);
+    addSettings(plugin, base)
     console.log('Loaded.')
     const requirePath = window.require.resolve(pluginPath)
     const watcher = chokidar.watch(requirePath, { depth: 0 })