chore: remove outdated crash reporting + remove donate dialog (#638)

* chore: remove crash reporting * chore: update donate dialog function * feat: remove donate dialog Co-authored-by: oguhpereira <[email protected]>
cerebroapp · Dec 28, 2022 · 3260eed · 3260eed
1 parent 0325364
commit 3260eed
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 90 deletions.
diff --git a/README.md b/README.md
@@ -67,10 +67,13 @@ If you'd like to install a version of Cerebro, but the executable hasn't been re
 
 1. Clone the repository
 2. Install dependencies with [yarn](https://yarnpkg.com/getting-started/install):
+
    ```bash
    yarn --force
    ```
+
 3. Build the package:
+
    ```bash
     yarn package
    ```

diff --git a/app/lib/config.js b/app/lib/config.js
@@ -14,11 +14,8 @@ const schema = {
   cleanOnHide: { type: 'boolean', default: true },
   selectOnShow: { type: 'boolean', default: false },
   hideOnBlur: { type: 'boolean', default: true },
-  skipDonateDialog: { type: 'boolean', default: false },
-  lastShownDonateDialog: { type: 'number', default: 0 },
   plugins: { type: 'object', default: {} },
   isMigratedPlugins: { type: 'boolean', default: false },
-  crashreportingEnabled: { type: 'boolean', default: true },
   openAtLogin: { type: 'boolean', default: true },
   winPosition: { type: 'array', default: [] },
 }
@@ -28,6 +25,9 @@ const store = new Store({
   migrations: {
     '>=0.9.0': (oldStore) => {
       oldStore.delete('positions')
+    },
+    '>=0.10.0': (oldStore) => {
+      oldStore.delete('crashreportingEnabled')
     }
   }
 })

diff --git a/app/main.development.js b/app/main.development.js
@@ -1,4 +1,4 @@
-import { app, ipcMain, crashReporter } from 'electron'
+import { app, ipcMain } from 'electron'
 import path from 'path'
 
 import createMainWindow from './main/createWindow'
@@ -22,21 +22,6 @@ let mainWindow
 let backgroundWindow
 let tray
 
-if (process.env.NODE_ENV !== 'development') {
-  // Set up crash reporter before creating windows in production builds
-  if (config.get('crashreportingEnabled')) {
-    crashReporter.start({
-      globalExtra: {
-        _companyName: 'Cerebro',
-      },
-      productName: 'Cerebro',
-      submitURL: 'http://crashes.cerebroapp.com/post',
-      autoSubmit: true,
-      compress: false
-    })
-  }
-}
-
 const setupEnvVariables = () => {
   process.env.CEREBRO_VERSION = app.getVersion()
 

diff --git a/app/main/createWindow.js b/app/main/createWindow.js
@@ -13,7 +13,6 @@ import {
 import buildMenu from './createWindow/buildMenu'
 import toggleWindow from './createWindow/toggleWindow'
 import handleUrl from './createWindow/handleUrl'
-import * as donateDialog from './createWindow/donateDialog'
 
 export default ({ src, isDev }) => {
   const [x, y] = config.get('winPosition')
@@ -169,10 +168,6 @@ export default ({ src, isDev }) => {
     })
   }
 
-  if (donateDialog.shouldShow()) {
-    setTimeout(donateDialog.show, 1000)
-  }
-
   // Save in config information, that application has been started
   config.set('firstStart', false)
 

diff --git a/app/main/createWindow/AppTray.js b/app/main/createWindow/AppTray.js
@@ -2,7 +2,6 @@ import { Menu, Tray, app } from 'electron'
 import showWindowWithTerm from './showWindowWithTerm'
 import toggleWindow from './toggleWindow'
 import checkForUpdates from './checkForUpdates'
-import { donate } from './donateDialog'
 
 /**
  * Class that controls state of icon in menu bar
@@ -61,10 +60,6 @@ export default class AppTray {
         click: checkForUpdates,
       },
       separator,
-      {
-        label: 'Donate...',
-        click: donate
-      }
     ]
 
     if (isDev) {

diff --git a/app/main/createWindow/donateDialog.js b/app/main/createWindow/donateDialog.js
diff --git a/app/plugins/core/settings/Settings/index.js b/app/plugins/core/settings/Settings/index.js
@@ -22,7 +22,6 @@ function Settings({ get, set }) {
     cleanOnHide: get('cleanOnHide'),
     selectOnShow: get('selectOnShow'),
     pluginsSettings: get('plugins'),
-    crashreportingEnabled: get('crashreportingEnabled'),
     openAtLogin: get('openAtLogin')
   }))
 
@@ -83,11 +82,6 @@ function Settings({ get, set }) {
         value={state.selectOnShow}
         onChange={(value) => changeConfig('selectOnShow', value)}
       />
-      <Checkbox
-        label="Send automatic crash reports (requires restart)"
-        value={state.crashreportingEnabled}
-        onChange={(value) => changeConfig('crashreportingEnabled', value)}
-      />
     </div>
   )
 }