Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE: migrate to electron 19 #11

Merged
merged 7 commits into from
Aug 27, 2022
Merged

CORE: migrate to electron 19 #11

merged 7 commits into from
Aug 27, 2022

Conversation

dubisdev
Copy link
Contributor

@dubisdev dubisdev commented Jul 1, 2022

Why

As we are updating cerebro, we also need packages that are using (now) outdated packages and APIs. This was using old remote module from electron.

Done

  • Updated electron methods openItem from shell module.
  • Now using @cerebroapp/cerebro-scripts for bundling
  • Using now @cerebroapp/cerebro-ui as cerebro-ui was using remote module.

Related issues

@dubisdev
Copy link
Contributor Author

dubisdev commented Jul 2, 2022

Hi @oguhpereira, the new version of cerebro-basic-apps is now ready and working with the future version of cerebro

Tested it on Ubuntu 20
plugin ubuntu

And Windows 11
image

🚧 As it is named @cerebroapp/cerebro-basic-apps it won't be installed in previous versions of Cerebroapp so it won't fail due to incompatible electron versions. Old versions will use the old plugin and new versions will use this.

Once new version of cerebro is ready, we can publish this without the alpha version 🚀

@ogustavo-pereira ogustavo-pereira merged commit 894bc53 into cerebroapp:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cerebro not listing apps (linux OpenSuse) Cerebro dependencies in package.json need updating
2 participants