Skip to content

Commit

Permalink
Fix deployer.exec() (#619)
Browse files Browse the repository at this point in the history
  • Loading branch information
dboreham authored Oct 30, 2023
1 parent 8cac598 commit 86076c7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions app/deploy/compose/deploy_docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ def port(self, service, private_port):
except DockerException as e:
raise DeployerException(e)

def execute(self, service, command, envs):
def execute(self, service, command, tty, envs):
try:
return self.docker.compose.execute(service=service, command=command, envs=envs)
return self.docker.compose.execute(service=service, command=command, tty=tty, envs=envs)
except DockerException as e:
raise DeployerException(e)

Expand Down
2 changes: 1 addition & 1 deletion app/deploy/deployer.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def port(self, service, private_port):
pass

@abstractmethod
def execute(self, service_name, command, envs):
def execute(self, service_name, command, tty, envs):
pass

@abstractmethod
Expand Down
2 changes: 1 addition & 1 deletion app/deploy/k8s/deploy_k8s.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def port(self, service, private_port):
# Also look into whether it makes sense to get ports for k8s
pass

def execute(self, service_name, command, envs):
def execute(self, service_name, command, tty, envs):
# Call the API to execute a command in a running container
pass

Expand Down

0 comments on commit 86076c7

Please sign in to comment.