Update RPC api and backend to support the EIP-2930 and EIP-1559. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-norden
reviewed
Jul 28, 2021
There was a problem hiding this comment.
Looks great! I think we should update/add some integration tests to test the RPC output of the new types vs the output of standard geth json-rpc.
Also related is vulcanize/ipld-eth-indexer#86 (review). Ideally we'd update to import from vulcanize geth rather than updating the ipld-eth-indexer dep. But this can be handled as the separate issue in a different PR if you'd prefer.
| @@ -8,7 +8,7 @@ SELECT exists(SELECT 1 | |||
| INNER JOIN eth.state_cids ON (storage_cids.state_id = state_cids.id) | |||
| INNER JOIN eth.header_cids ON (state_cids.header_id = header_cids.id) | |||
| WHERE storage_path = path | |||
| AND block_number > height | |||
| AND block_number >= height | |||
There was a problem hiding this comment.
If this needs changed the comment for the function should be updated too
This was referenced Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78