Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose and CI #6

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Docker compose and CI #6

merged 4 commits into from
Sep 9, 2020

Conversation

ramilexe
Copy link
Contributor

@ramilexe ramilexe commented Sep 9, 2020

Integration with eth-indexer, dapptools, postgraphile

@ramilexe ramilexe requested review from i-norden and roysc September 9, 2020 15:54
@ramilexe ramilexe mentioned this pull request Sep 9, 2020
Closed
i-norden
i-norden approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't find anything to fix, I commented one minor optional cleanup.

entrypoint.sh Outdated Show resolved Hide resolved
pkg/serve/config.go Show resolved Hide resolved
@ramilexe ramilexe merged commit b5fc0e7 into master Sep 9, 2020
@i-norden i-norden deleted the docker branch November 1, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-norden i-norden i-norden approved these changes

@roysc roysc Awaiting requested review from roysc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramilexe @i-norden