New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use geth's eth API instead of ethclient on missing blocks for getHeaderByHash #181

Merged

ashwinphatak merged 1 commit into sharding from pm-change-getheaderbyhash

Jul 20, 2022

Contributor

prathamesh0 commented Jul 19, 2022

Part of #180

Use geth's eth API instead of ethclient on missing blocks for getHeaderByHash
- To maintain compatibility with geth's eth API, GetHeaderByHash() is required to include totalDifficulty in the result
- ethclient's HeaderByHash method returns just the header object which doesn't have the totalDifficulty
- Since geth's getHeaderByHash API implementation includes totalDifficulty in the result, it is not required to be fetched separately


          Use geth's eth API on missing blocks for getHeaderByHash

115e78c

prathamesh0 requested a review from ashwinphatak

July 19, 2022 15:03

prathamesh0 self-assigned this

ashwinphatak approved these changes

View reviewed changes

ashwinphatak merged commit ba01123 into sharding

ashwinphatak deleted the pm-change-getheaderbyhash branch

July 20, 2022 04:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet