Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the build and push steps. #151

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

abdulrabbani00
Copy link
Contributor

No description provided.

@abdulrabbani00
Copy link
Contributor Author

The tests are failing even though I have not made any application changes, just CI/CD changes.

The CI/CD changes have been tested: https://github.com/vulcanize/ipld-eth-server/actions/runs/2347537403

@ashwinphatak
Copy link
Collaborator

The tests are failing even though I have not made any application changes, just CI/CD changes.

The CI/CD changes have been tested: https://github.com/vulcanize/ipld-eth-server/actions/runs/2347537403

Looks like a recent change in one of the deps: denisenkom/go-mssqldb#745

We are investigating it.

@abdulrabbani00
Copy link
Contributor Author

@ashwinphatak - The issue was resolved by the dev team. Merging the change.

@abdulrabbani00 abdulrabbani00 merged commit be34f0e into master May 19, 2022
@abdulrabbani00 abdulrabbani00 deleted the feature/cicd-docker-tag branch May 19, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants