Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedup receipt #103

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Dedup receipt #103

merged 6 commits into from
Sep 22, 2021

Conversation

arijitAD
Copy link
Contributor

No description provided.

i-norden
i-norden approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments and a question, thanks!

pkg/eth/filterer.go Outdated Show resolved Hide resolved
pkg/eth/ipld_retriever.go Outdated Show resolved Hide resolved
pkg/eth/ipld_retriever.go Outdated Show resolved Hide resolved
pkg/eth/test_helpers.go Outdated Show resolved Hide resolved
pkg/eth/cid_retriever.go Outdated Show resolved Hide resolved
pkg/eth/ipld_retriever.go Outdated Show resolved Hide resolved
pkg/eth/ipld_retriever.go Outdated Show resolved Hide resolved
@arijitAD arijitAD mentioned this pull request Sep 20, 2021
Merged
@i-norden i-norden mentioned this pull request Sep 21, 2021
Closed
@arijitAD arijitAD merged commit ec3165f into master Sep 22, 2021
@arijitAD arijitAD deleted the dedup-receipt branch September 22, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-norden i-norden i-norden approved these changes

@ashwinphatak ashwinphatak Awaiting requested review from ashwinphatak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arijitAD @i-norden