Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a table for watched addresses (v3) #54

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

nikugogoi
Copy link
Contributor

Part of cerc-io/go-ethereum#127

  • Migration for a table that stores watched addresses used in geth for direct indexing

Passing GO111MODULE=off with go get throws error. The CI fails due to this when using the makefile.
@ashwinphatak ashwinphatak requested a review from i-norden March 21, 2022 12:55
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@i-norden
Copy link
Collaborator

i-norden commented Mar 22, 2022

Ashwin already indicated this was known, but we should add the updated UML diagram. Doesn't necessarily have to be on this PR though. We also need to add this new table to the pre- and post- migration sets but I'll do that in a separate PR as it has to be added at a specific migration number and I need to double check with Shane which one our prod DB is at.

@i-norden i-norden merged commit d8dbd14 into cerc-io:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants