Vdb 833 more robust statediffing tests #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
VDB-833-more-robust-statediffing-tests
branch
3 times, most recently
from
0423e80 to
965dd84
Compare
elizabethengelman
requested review from
aaizuss,
Gslaughl,
i-norden,
m0ar,
rmulhol and
yaoandrew
elizabethengelman
changed the title
elizabethengelman
force-pushed
the
VDB-833-more-robust-statediffing-tests
branch
from
965dd84 to
f5cab3a
Compare
… types Update test account variable names with block numbers
elizabethengelman
changed the title
elizabethengelman
force-pushed
the
VDB-833-more-robust-statediffing-tests
branch
from
f5cab3a to
f51d44d
Compare
i-norden
approved these changes
Sep 20, 2019
i-norden
reviewed
Sep 20, 2019
| //slot 1: mapping(uint => TestStruct) | ||
| // calculate key for TestStruct.var1 | ||
| testStructVar1Key = calculateTestStructStorageKey() // cc69885fda6bcc1a4ace058b4a62bf5e179ea78fd58a1ccd71c22cc9b688792f | ||
| keccakOfTestStructVar1Key = crypto.Keccak256Hash(testStructVar1Key.Bytes()) // the statediff service is currently emitting the key as a keccak hash |
There was a problem hiding this comment.
I see how the emitted keys are so confusing now, since calculateTestStructStorageKey already returns a hash/the key itself is already a hash.
i-norden
added a commit
that referenced
this pull request
Feb 2, 2020
Modifications to message struct
i-norden
pushed a commit
that referenced
this pull request
Sep 14, 2020
* eth-sign: initial implementation * sighash: pre-refactor * sighash: refactor, all old tests pass * sighash: test ovmsigner code paths for eip155 and eth_sign * sighash: tx serialization tests * sighash: refactor to sign bytes * common/varbytes: use varbytes serialization from btcd * transactionmeta: implement and test * rawdb: add new index * types/transaction: use txmeta * blockchain: index tx meta on new block * rpc: fix sendrawethsigntransaction docstring * meta test: remove dead code * ethapi: clean up comment * lint: fix * txmeta: clean up compares * ethapi: remove rlp tag * signer: remove rlp encoding tags from struct * types: use factory pattern for getting sighash type * sighash: migrate to using const * tx pool: use ovmsigner for tx validation * tx signing: fix eth_sign serialization * sighash: new version * sighash: commit to chainid * sighash: bugfixes * core/types: prevent panic on tx sort * core/types: rename to transaction_meta * core/blockchain: index txmeta * sighash: no native value * ethapi: use ovm signer * sighash: move chainid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the contract that's being used to test the statediffing work. The biggest change is that
TestContractnow has different data types in it's storage: bytes32, address, uint48, uint256[10], mapping(uint => TestStruct).Note: I was having trouble calculating the TestStruct storage key earlier, but I think it was a silly mistake that I figured out, and it is now working. i.e. common.HexToHash(“3”) !=common.Hex2Bytes(“03”) != common.Hex2Bytes(“3”) 🤦♀
This should be ready for review finally! 😅