-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gRPC client and admin API capabilities #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
…k.grpc.client` module. added tests Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
Signed-off-by: Sam Lock <[email protected]>
charithe
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Kudos for wading through the madness of Python gRPC generated code 🙌🏽
Co-authored-by: Charith Ellawala <[email protected]> Signed-off-by: Sam Lock <[email protected]>
…efinitions in-situ Signed-off-by: Sam Lock <[email protected]>
Sambigeara
force-pushed
the
enhancement/admin-api-support
branch
from
July 11, 2023 11:23
51244f8
to
47db2ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new gRPC client whilst maintaining backwards compatibility with the old HTTP client. It also adds support to access the admin API via the new gRPC client.
closes #27