Remove deprecated exportloopref linter and add copyloopvar instead

Signed-off-by: Andrew Haines <[email protected]>
cerbos · Nov 4, 2024 · 7124e18 · 7124e18
1 parent f1ac4fb
commit 7124e18
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -51,11 +51,11 @@ linters:
     - asciicheck
     - bidichk
     - bodyclose
+    - copyloopvar
     - dupl
     - durationcheck
     - errorlint
     - exhaustive
-    - exportloopref
     - forbidigo
     - forcetypeassert
     - goconst

diff --git a/cerbos/grpc_admin_test.go b/cerbos/grpc_admin_test.go
@@ -214,7 +214,6 @@ func TestAdminClient(t *testing.T) {
 		}
 
 		for _, tc := range testCases {
-			tc := tc
 			t.Run(tc.name, func(t *testing.T) {
 				have, err := ac.ListPolicies(context.Background(), tc.options...)
 				require.NoError(t, err)
@@ -299,7 +298,6 @@ func TestAdminClient(t *testing.T) {
 		}
 
 		for _, tc := range testCases {
-			tc := tc
 			t.Run(tc.name, func(t *testing.T) {
 				have, err := ac.InspectPolicies(context.Background(), tc.options...)
 				require.NoError(t, err)

diff --git a/cerbos/grpc_test.go b/cerbos/grpc_test.go
@@ -54,7 +54,6 @@ func TestGRPCClient(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Run("tcp", func(t *testing.T) {
 				s, err := launcher.Launch(testutil.LaunchConf{