-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose current ceramic network via api #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
stbrody
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod question about namespacing the endpoint
we now return the names used previously by js-ceramic rather than something that looks like a pubsub topic. this could be subtly breaking, but afaict, nothing uses or relies on this currently. we could instead impl Display or another function to get this value, but given the unused nature I'm preferring one version unless others deem that a mistake.
this matches js-ceramic. it's not advertised in shell completion but will be accepted
dav1do
force-pushed
the
feat/aes-209-expose-current-network
branch
from
July 25, 2024 23:07
fcebc04
to
4123066
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new endpoint to support retrieving the current network the server is connected to. I changing the name formatting to remove
/ceramic/
and return the values that match more closely to what we previously used in js-ceramic. It is possibly a subtly breaking change if people were relying on this string representation to match the pubsub topics, but I can't find any uses in the repo, http client or keramik so went ahead and changed it. Open to implementingDisplay
or another function instead if others deem that worthwhile.I also added
inmemory
as an alias ofin-memory
for the network cli flag so either can be passed in. It's not advertised in help/completion but it will work if passed in.