feat: track version history in database #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
force-pushed
the
feat/aes-160-track-version
branch
from
2ed9b69 to
f23f243
Compare
|
@dav1do is this still something we want to move forward with getting in place? |
This can be used in the future to prevent downgrades that go across incompatible schema/data migrations
dav1do
force-pushed
the
feat/aes-160-track-version
branch
from
612ed7d to
d10803a
Compare
I rebased it as I think it's kind of nice to have, but I don't feel strongly that it's important. The ticket became less necessary as we didn't end up needing to migrate c1 data for GA. We may want this (plus something more like the changes in #382) if we need to make changes to data/schemas for event validation or the conclusion API. |
nathanielc
approved these changes
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic right now. Stores the current version in the database at daemon startup. This can be used in the future to prevent downgrades that go across migrations. Related to #382 but split off as we don't need to migrate any data right now.